-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: Component task-ilo-alignment-modal.coffee Review Document #49
Open
JayaniVimukthika
wants to merge
6
commits into
thoth-tech:main
Choose a base branch
from
JayaniVimukthika:ilo-alignment-modal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migration: Component task-ilo-alignment-modal.coffee Review Document #49
JayaniVimukthika
wants to merge
6
commits into
thoth-tech:main
from
JayaniVimukthika:ilo-alignment-modal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for strong-fairy-c1bde1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for thoth-tech ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@williamalowe will be reviewing this. |
Reviewed 14/12/2023 - COPIED FROM PREVIOUS REPO ##Purpose
##Outcomes
##Proposal
##Checklist
##Other notes
Re-reviewed 15/12/2023
|
Went through the contributing document, and passed all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the first step of Migration: Component task-ilo-alignment-modal.coffee, comepleted the component review and created the markdown document.
Fixes # (issue)
No issues
Type of change
went through the component and reviewed how function works.
created the markdown document.
The previous PR:
https://github.com/thoth-tech/documentation/pull/472
expected)
Checklist